Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page_label to JSON output #81

Merged
merged 4 commits into from
Aug 10, 2023
Merged

Conversation

linozen
Copy link
Contributor

@linozen linozen commented Aug 9, 2023

The method annot_to_dict in json.py has also been refactored to remove keys with None values in the nested dictionary. This improves the clarity and reduces unnecessary data in the resulting dictionary.

This is basically the commit which does not belong to #79 (I will revert it there now)

The method `annot_to_dict` in json.py has also been refactored to remove keys with None values in the nested dictionary. This improves the clarity and reduces unnecessary data in the resulting dictionary.
@linozen linozen changed the title feat(json): add page_number to output Add page_number to JSON output Aug 9, 2023
pdfannots/printer/json.py Outdated Show resolved Hide resolved
pdfannots/printer/json.py Outdated Show resolved Hide resolved
pdfannots/printer/json.py Outdated Show resolved Hide resolved
pdfannots/printer/json.py Outdated Show resolved Hide resolved
Copy link
Owner

@0xabu 0xabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to make you do another round here. Can you change page_number back to page?

If not I'll finish it tonight.

@0xabu 0xabu changed the title Add page_number to JSON output Add page_label to JSON output Aug 10, 2023
@0xabu 0xabu merged commit 41c9544 into 0xabu:main Aug 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants